-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare pserver executor #9377
prepare pserver executor #9377
Conversation
… prepare_pserver_executor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and one comment.
framework::Async([&executor, &prepared, &program, &scope, idx]() { | ||
int run_block = idx; // thread local | ||
try { | ||
// executor->Run(*program, scope, run_block, false, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May delete the unused codes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
6246fc6
to
1fccfc3
Compare
1fccfc3
to
44c29ab
Compare
… prepare_pserver_executor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM again
Background: #8638